-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering incorrectly assumes output image has padding of four #76
Comments
@MustafaJafar could you describe the steps to reproduce the issue? Local rendering with Mantra ROP with |
I made another test run from the develop branch and it still tells:
on my disk the file names look like this:
I can't remember if we have something like |
On the other hand, it works as expected when disabling the Transcode plugin.
|
So, to reproduce:
Is that correct? |
Another issue with Transcoding is it doesn't work with AOVs. Deadline Log
Local Publish Log
|
@MustafaJafar yes - thanks. That is entirely correct and would be a bug for local render instances. This plugin runs after the collecting of the local render instances... as such - these instances do not have the colorspace data because they are of a different family. We may want to run the collect local render instances AFTER the colorspace collecting and transfer the relevant data to the AOV instances? |
This plugin should applies the following filter which adds but based on my profile configuration, And when they don't have a review tag, they will most likely fail because of no proper channel to convert. Traceback (most recent call last):
File "C:\Users\Mustafa Taher\AppData\Local\Ynput\AYON\dependency_packages\ayon_2408011901_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
runner(*args)
File "E:\Ynput\ayon-core\client\ayon_core\plugins\publish\extract_color_transcode.py", line 157, in process
convert_colorspace(
File "E:\Ynput\ayon-core\client\ayon_core\lib\transcoding.py", line 1141, in convert_colorspace
input_arg, channels_arg = get_oiio_input_and_channel_args(input_info)
File "E:\Ynput\ayon-core\client\ayon_core\lib\transcoding.py", line 1432, in get_oiio_input_and_channel_args
raise ValueError(
ValueError: Couldn't find channels that can be used for conversion. |
It does sound like a clear separate issue - could you spin of a new issue with clear reproducable steps and include all the details from above? Thanks. It seems separate enough from the frame padding issue to warrant being a separate issue. |
Thank you. |
Here's an error that I faced by accident. I assume it's not related to this PR.
I had
$F5
in my file path. which led to thisalso,
Originally posted by @MustafaJafar in #75 (comment)
Steps To Reproduce:
$F5
The text was updated successfully, but these errors were encountered: