You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, first of all thank you for creating this library!
I am working on a larger project where I use MDUI with HTMX. When sending form data to a server with htmx, the submit button adds an empty field without a value to the request. I created a minimal example to reproduce:
<!DOCTYPE HTML><htmllang="en" class="mdui-theme-dark"><head><metacontent="text/html; charset=UTF-8" http-equiv="Content-Type"><metacontent="width=device-width,initial-scale=1.0" name=viewport><scriptsrc="static/external/htmx.js"></script><linkrel="stylesheet" href="https://unpkg.com/mdui@2/mdui.css"><scriptsrc="https://unpkg.com/mdui@2/mdui.global.js"></script><scriptsrc="https://unpkg.com/[email protected]"></script></head><body><!-- fake api that allows all cors traffic --><basehref="https://jsonplaceholder.typicode.com"><formhx-post="/posts"><mdui-top-app-bar-title>
Title
</mdui-top-app-bar-title><mdui-text-fieldlabel="Username" name="username"></mdui-text-field><mdui-text-fieldlabel="Password" name="password"></mdui-text-field><mdui-buttontype="submit">Login</mdui-button></form></body></html>
With the above example, here is what the login button looks like in the dom:
HTMX sees the name and the value attributes and includes them in the form data (which is expected behavior with htmx).
Here is what the form data looks like with the code above:
I found an example on the lit.dev playground where the properties of components are defined as optionals. The attributes are not displayed there because they are left undefined by default. On the ButtonBase in MDUI the attributes have a default value which is an empty string. I think attributes in MDUI should be made optional as well as empty string values still have a value (which is a string without any characters) while undefined is, as far as I know, the expected way to mark something optional in JavaScript.
Thanks again for creating MDUI. I hope this can get resolved 🙂
The text was updated successfully, but these errors were encountered:
Hey, first of all thank you for creating this library!
I am working on a larger project where I use MDUI with HTMX. When sending form data to a server with htmx, the submit button adds an empty field without a value to the request. I created a minimal example to reproduce:
With the above example, here is what the login button looks like in the dom:
HTMX sees the name and the value attributes and includes them in the form data (which is expected behavior with htmx).
Here is what the form data looks like with the code above:
I found an example on the lit.dev playground where the properties of components are defined as optionals. The attributes are not displayed there because they are left
undefinedby default. On theButtonBasein MDUI the attributes have a default value which is an empty string. I think attributes in MDUI should be made optional as well as empty string values still have a value (which is a string without any characters) whileundefinedis, as far as I know, the expected way to mark something optional in JavaScript.Thanks again for creating MDUI. I hope this can get resolved 🙂
The text was updated successfully, but these errors were encountered: