Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labeling and implementation of IPC/non-IPC connection modes. #87

Open
alanseiden opened this issue Jul 13, 2016 · 2 comments
Open
Assignees
Milestone

Comments

@alanseiden
Copy link
Collaborator

Replace the terminology and implementation of "internal key" and "stateless" to make connections easier to understand. Many users doing it wrong (causing terrible problems) because they didn't understand the IPC concept (/tmp/alan) and because the PHP toolkit 1.x defaults to stateful mode using the same key for everyone (/tmp/Toolkit). Tony suggests creating a main class (Base) that specific connection mode classes could inherit from. Name them well. Alan suggests "privateJob" or the like for stateful connections. Hide the IPC concept. Perhaps accept a key that the toolkit adds to /tmp.

@alanseiden alanseiden added this to the 2.0 milestone Jul 13, 2016
@alanseiden
Copy link
Collaborator Author

Good ideas but four years later with more toolkit userland code written, we don't relish the backward compatibility break. At this stage, we suggest better code examples with accurate comments. Close the issue after relevant documentation/example issues have been created.

@alanseiden
Copy link
Collaborator Author

Examples to be written:

  • stateless option set with explanation
  • stateful option with explanation of why not to use /tmp/Toolkit and about disconnecting.

Create an issue for each of the above, or a single issue for both examples to be written.

@alanseiden alanseiden self-assigned this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant