WIP: LG-14503 Update USPS Proofing Job To Not Override Deactivation Codes on Profile

[gina-yamada]

🎫 Ticket

LG-14503 Update USPS Proofing Results Job exclude overwriting profile deactivation reason

🛠 Summary of changes

• Update method deactivate_due_to_in_person_verification_cancelled to only update profile with a deactivation reason when it does not already exist. We do not want to override password_reset or encryption_error to preserves the history.

📜 Testing Plan

• Step 1 It is helpful to add get_usps_proofing_results_job_cron: '0/59 * * * *' or some version to config/application.yml to delay the job from running so you have time to test. (The job will run on the 59 min of the hour.)

Check that there is not a regression. (A profile that has an enrollment that either expired, was cancelled, or failed gets verification_cancelled assigned as the deactivation reason.)

• Step 2 Starting in Sinatra, create an account go through ID-IPP flow to create an enrollment- get to Ready to Verify (barcode page). In a different terminal open the rails console
• Step 3 Run the job using the following commands

e = InPersonEnrollment.last
res = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_failed_proofing_results_response)
job = GetUspsProofingResultsJob.new
job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0, enrollments_errored: 0, enrollments_expired: 0, enrollments_checked: 0 })
job.send(:process_enrollment_response, e, res)

• Step 4 Verify the data. (1. Enrollment status is failed 2. Profile is not active 3. Profile deactivation reason is verification_cancelled)
• Step 5 Optional: Repeat steps 2-4 for each- cancelled and expired enrollments

Check new functionality

• Step 6 - [ ] Step 2 Starting in Sinatra, create an account (use [email protected] so you can get an email delivered to reset your PW), go through ID-IPP flow to create an enrollment- get to Ready to Verify (barcode page). In a different terminal open the rails console
• Step 7 Verify the data. (1. Enrollment status is pending 2. Profile is not active 3. Profile deactivation reason is nil)
• Step 8 Sign out. Perform a password reset via Forgot you password on the sign in page of Login.
• Step 9 Sign in. Verify the data. (1. Enrollment status is pending 2. Profile is not active 3. Profile deactivation reason is encyption_error).
• Step 10 Run the job using the following commands

e = InPersonEnrollment.last
res = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_failed_proofing_results_response)
job = GetUspsProofingResultsJob.new
job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0, enrollments_errored: 0, enrollments_expired: 0, enrollments_checked: 0 })
job.send(:process_enrollment_response, e, res)

• Step 11 Verify the data. (1. Enrollment status is cancelled 2. Profile is not active 3. Profile deactivation reason is encryption_error).

• Step 12

[mitchellhenke]

Is there a way to combine this into one UPDATE to avoid the extra database call?

[zachmargolis]

maybe like this?

Suggested change

	update!(active: false, in_person_verification_pending_at: nil)
	update!(deactivation_reason: :verification_cancelled) if !deactivation_reason.present?
	to_update = {
	active: false,
	in_person_verification_pending_at: nil
	}.tap do |attrs|
	attrs[:deactivation_reason] = :verification_cancelled if deactivation_reason.blank?
	end
	update!(to_update)

[zachmargolis]

or maybe something like this:

Suggested change

	update!(active: false, in_person_verification_pending_at: nil)
	update!(deactivation_reason: :verification_cancelled) if !deactivation_reason.present?
	update!(
	active: false,
	in_person_verification_pending_at: nil,
	deactivation_reason: deactivation_reason.presence || :verification_cancelled,
	)

[gina-yamada]

I had never seen tap before- helpful method. Ultimately, I went went suggestion 2. Resolved with commit d0b5cb4