Issue 6316 - lmdb reindex is broken if index type is specified #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbordaz
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
a typo and some questions.
Also is it related to the failure dogtagpki/pki#4839 ?
|
@tbordaz It is the issue with discussed in chat. |
progier389
force-pushed
the
i6316
branch
2 times, most recently
from
f71e934
to
acee615
Compare
droideck
approved these changes
Sep 5, 2024
tbordaz
reviewed
Sep 6, 2024
| assert keys2p > 0 | ||
| assert keys2s > 0 | ||
|
|
||
| # Reindex 'cn' without types |
There was a problem hiding this comment.
minor: this is "attr" not " 'cn'"
vashirov
pushed a commit
that referenced
this pull request
Sep 16, 2024
While reindexing using task or offline reindex, if the attribute name contains the index type (for example :eq,pres) Then the attribute is not reindexed. Problem occurs when lmdb is used, things are working fine with bdb. Solution: strip the index type in reindex as it is done in bdb case. Anyway the reindex design requires that for a given attribute all the configured index types must be rebuild. Issue: #6316 Reviewed by: @tbordaz, @droideck (Thanks!)
vashirov
pushed a commit
that referenced
this pull request
Sep 16, 2024
While reindexing using task or offline reindex, if the attribute name contains the index type (for example :eq,pres) Then the attribute is not reindexed. Problem occurs when lmdb is used, things are working fine with bdb. Solution: strip the index type in reindex as it is done in bdb case. Anyway the reindex design requires that for a given attribute all the configured index types must be rebuild. Issue: #6316 Reviewed by: @tbordaz, @droideck (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reindexing using task or offline reindex, if the attribute name contains the index type (for example :eq,pres)
Then the attribute is not reindexed. Problem occurs when lmdb is used, things are working fine with bdb.
Solution: strip the index type in reindex as it is done in bdb case.
Anyway the reindex design requires that for a given attribute all the configured index types must be rebuild.
Issue: #6316
Reviewed by: @tbordaz, @droideck (Thanks!)