온보딩 프로젝트 2단계 제출 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authType -> roleType
mike2ox
reviewed
Apr 19, 2023
| import { Home, Login, PageA, PageB, Manager, Admin, NotFound } from '../pages'; | ||
| import { roleType } from '../types'; | ||
|
|
||
| export const routes = [ |
There was a problem hiding this comment.
이런 방식으로 route를 관리하는 방식도 있군요. 공부됐어요 👍
Comment on lines
+3
to
+11
| .wrapper { | ||
| @include flex-column; | ||
| position: absolute; | ||
| top: $header-height; | ||
| left: 0; | ||
| width: $sidebar-width; | ||
| height: $body-height; | ||
| border-right: $section-border-weight solid $dark-blue; | ||
| } |
There was a problem hiding this comment.
페이지가 많아졌을때를 고려해서 js는 잘 짜셨는데 css에서 overflow가 없어서 사이드바에 있는 메뉴가 많아지지 스크롤시 스타일이 이상하게 동작하더라구요. 한번 확인해주세요
| SUCCESS: 'success', | ||
| FAIL: 'fail', | ||
| }; | ||
| Object.freeze(loginResultType); |
There was a problem hiding this comment.
object.freeze의 기능을 한번 더 복습하는 시간이었어요 ㅎㅎ 👍
Comment on lines
+20
to
+24
| return { | ||
| res: loginResultType.FAIL, | ||
| data: await loginRes.json(), | ||
| }; | ||
| }; |
There was a problem hiding this comment.
try-catch없어도 요청에서 실패하면 여기서 잡히는지 궁금하네요.
Comment on lines
+5
to
+36
| export function useUser() { | ||
| const [user, setUser] = useRecoilState(userState); | ||
| const resetUser = useResetRecoilState(userState); | ||
| const [loading, setLoading] = useState(true); | ||
| const [error, setError] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| async function fetchUser() { | ||
| try { | ||
| const res = await fetch('/user', { | ||
| method: 'GET', | ||
| headers: { | ||
| credentials: 'include', | ||
| }, | ||
| }); | ||
| if (!res.ok) { | ||
| throw new Error('Failed to load user'); | ||
| } | ||
| const user = await res.json(); | ||
| setUser(user); | ||
| setLoading(false); | ||
| } catch (e) { | ||
| setError(true); | ||
| setLoading(false); | ||
| } | ||
| } | ||
| if (user) { | ||
| return; | ||
| } | ||
| fetchUser(); | ||
| }, [user]); | ||
| return { user, loading, error, resetUser }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능