Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAL-6 #done #2

Merged
merged 14 commits into from
Mar 29, 2024
Merged

CHAL-6 #done #2

merged 14 commits into from
Mar 29, 2024

Conversation

dvorakjt
Copy link
Contributor

@dvorakjt dvorakjt commented Mar 29, 2024

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Include the corresponding Jira issue key and #done in the PR title, like so: "JRA-123 #done Migrate Election Reminders"
  • Verify that the code compiles
  • Verify that all tests pass
  • Verify that unit tests cover 100% of the code
  • Create Storybook stories for visual components
  • Verify that any visual components match the Figma
  • Test with a screen reader (if applicable)
  • Document your code with TSDoc comments
  • Format your code with Prettier

Overview

This PR creates a ServicesContext which is able to provide instances of service classes to child components via a dependency injection container. Additionally, it defines an AbstractUserService class and a partial implementation of this class--LocalUserService--for other developers to complete, and updates the User model to more accurately reflect the player stories regarding contributing to challengers. (see https://www.figma.com/file/0Q2tpQqi9sYcIA3ZyiX3PF/8BY8_POD_Jul30 - Mocks, December Version, US3 - US7).

Test Plan

Unit tests have been implemented for the ServicesContextProvider and the servicesContainer. The LocalUserService is currently added to the coveragePathIgnorePatterns array in jest.config.mjs and must be removed from this array once it is fully implemented. In order to test the ServicesContextProvider, getProvidedContextValue() was added to testing-utils.

Follow ups

The LocalUserService class must be implemented and tested. Once this is implemented, UserContextProvider should also be tested.

@dvorakjt dvorakjt merged commit 90192bc into 8by8-org:development Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant