-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chal 16 #27
Chal 16 #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Noreen,
Looks great! Only two things:
- Please fetch and merge the latest changes in from upstream/development and then push these changes to your fork
- Please remove the
data-testid
prop from the PageContainer component as this is unused. Then regenerate the snapshots by runningnpm test -- -u
This is great, thank you!
@@ -7,7 +7,7 @@ import styles from './styles.module.scss'; | |||
*/ | |||
export function PageContainer({ children }: PropsWithChildren) { | |||
return ( | |||
<div className={styles.outer_container}> | |||
<div className={styles.outer_container} data-testid="page-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove data-testid here as it is unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, approved!
Checklist
Overview
Test Plan
Follow ups