Restart Challenge #37
Conversation
There was a problem hiding this comment.
Looks very good. There are some minor nits to take care of, and you will need to write tests for the code you've added. See the comments that I added to each file for more details. That's about all I see, so once you take care of those things, we'll be able to merge this :)
|
|
||
| try { | ||
| const data = await request.json(); | ||
| const { userId } = restartChallengeSchema.parse(data); |
There was a problem hiding this comment.
^ I don't think this route actualy needs a schema, or to read any data from the request body, for that matter. I think you can just use the Auth class to get the user from cookies.
|
|
||
| const user = await auth.loadSessionUser(); | ||
| // impossible that frontend and cookie issue. | ||
| if (!user || user.uid !== userId) { |
There was a problem hiding this comment.
^ Please remove vestigial comments such as this one and the one on line 24
| return NextResponse.json({ error: e.message }, { status: e.statusCode }); | ||
| } | ||
|
|
||
| return NextResponse.json({ error: 'Bad data.' }, { status: 400 }); |
There was a problem hiding this comment.
Because this route will no longer be parsing a request body, this catch all statement should probably be a 500 error code with a more general error message.
| try{ | ||
| setLoading(true); | ||
| await restartChallenge(); | ||
| } catch (error) {} |
There was a problem hiding this comment.
Maybe use the AlertsContext to show the user an error message if this fails?
| } | ||
|
|
||
| return updatedChallengeEndTimestamp; | ||
| //follow the style of getUserById AND supabase->throw an error |
There was a problem hiding this comment.
^ Please remove this comment.
There was a problem hiding this comment.
Could you tidy up the vertical whitespace in this file, please?
There was a problem hiding this comment.
The button component has been moved to src/components/utils/button, so all the folder src/components/button and all its contents can safely be deleted.
Checklist
Overview
Test Plan
Follow ups