Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAL-12 #done #5

Merged
merged 1 commit into from
Apr 8, 2024
Merged

CHAL-12 #done #5

merged 1 commit into from
Apr 8, 2024

Conversation

JyyHuang
Copy link
Contributor

@JyyHuang JyyHuang commented Apr 8, 2024

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Include the corresponding Jira issue key and #done in the PR title, like so: "JRA-123 #done Migrate Election Reminders"
  • Verify that the code compiles
  • Verify that all tests pass
  • Verify that unit tests cover 100% of the code
  • Create Storybook stories for visual components
  • Verify that any visual components match the Figma
  • Test with a screen reader (if applicable)
  • Document your code with TSDoc comments
  • Format your code with Prettier

Overview

Replaced the speech bubble graphic on the why8by8 page as old image had a different background.

Test Plan

Updated snapshot test and confirmed changes with storybook.

Follow ups

N/A

@JyyHuang JyyHuang requested a review from dvorakjt April 8, 2024 19:31
Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We'll get another issue assigned to you shortly. Thank you!

@dvorakjt dvorakjt merged commit abc2684 into 8by8-org:development Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants