Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addie's Random Menu #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

add2point71dots
Copy link

Mood Analysis

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Would a hash work just as well as an Array in this project? Why? I think an array works better than a hash for this project because (at least the way I did it) there are no pairs of information that go together. I think it's simpler to get a random sample from an array, as well, though I haven't experimented with that with hashes much, so I could be wrong. Actually, a hash of arrays might have worked out alright. Like a hash with the key "adjectives" that gives you the value of an array of adjectives, etc.
Did you find yourself repeating the same code? Why did you have to do it that way? I don't think I had too much repetition. I defined a couple of methods to try to avoid repetition.
What type of loop did you use? Why did you choose that type? I used times for displaying results, since I was basing it off of what user input for how many results to display. I used times for getting adjectives from users, as well. I also used while and until to verify inputs from the user, since they need to run until I get input that fits my purposes.

@kariabancroft
Copy link

Random Menu

What We're Looking For

Feature Feedback
Random Menu of 10 items displayed in the terminal. Yep + optional to allow the user to choose. You did a nice job creating the checks to ensure that the user didn't select a value that was greater than the num of items that you could display in the arrays.
Generator pulls one random item from each array to create menu items. Yep + optional to ensure that each item was only chosen one time per menu item.
Baseline
Readable code with consistent indentation. Indentation and code style looks good.
Extras
You did a nice job using method to encapsulate some of the functionality that you'd use again.
Nice job using the until loop to ensure the user has chosen one of the valid options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants