Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks- Rana- TaskList #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

RanaSulaiman
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model is a child class from ActiveRecord that enable us to use all ActiveRecord methods to DRY our code. These methods include all, find, create, count and more. Also the model holds all the data that can be retrieved by the controller
Describe in your own words what the Controller is doing in Rails Controller is a class that has all the logic and methods (actions) that are necessary for the project. Controller controls and handle the browser requests (which sent from the router) so it will retrieve data from the model or send the required message to the view.
Describe in your own words what the View is doing in Rails View is responsible of rendering the html/css and all embedded ruby code in the browser based on the controller messages.
What is the purpose of using strong params? (i.e. the params method in the controller) is to prevent the user of slipping any malicious data to our project
How are Rails migrations related to Rails models? we use migration to change the database structure of which the model can communicate with. We can generate migration of a model that will create an empty table or database.
Describe one area of Rails that are still unclear on Sometimes it is not clear how the routes and controller interact together.

@CheezItMan
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in A little more committing would be better.
Answered comprehension questions Check
Successfully handles: Index, Show Check
Successfully handles: New, Create It would be a good idea to add some logic to handle if the user doesn't give you a completion date when they create a new task. Otherwise it works well
Successfully handles: Edit, Update Check
Successfully handles: Destroy, Task Complete Check, very nice work with the emoji link to mark a task as complete.
Routes follow RESTful conventions Check, well done.
Uses named routes (like _path) Check
Overall Nicely done, you got all the requirement in. Your CSS could be a bit DRYer, but the site is nicely formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants