Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sai's task list #24

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

sai's task list #24

wants to merge 14 commits into from

Conversation

ssamant
Copy link

@ssamant ssamant commented Mar 26, 2017

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails the model is talking between the controller and the db
Describe in your own words what the Controller is doing in Rails the controller is sending out messages to the model and the views
Describe in your own words what the View is doing in Rails the view is setting up the html to be sent back to the user
What is the purpose of using strong params? (i.e. the params method in the controller) to make sure bad data can't get into your db; you can specify which columns in the db can be updated
How are Rails migrations related to Rails models? migrations change the structure of the database (which is accessed through a model)
Describe one area of Rails that are still unclear on hmmm many things, but maybe how the view gets back to the users; also what is singular/plural, what needs to be a symbol vs variable, etc.

@CheezItMan
Copy link

CheezItMan commented Apr 2, 2017

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Check
Answered comprehension questions Check, it's fairly normal to be confused on the plural vs singular terms. Just remember, Model: Singular, Controller & Database Table: Plural. Otherwise, if you can focus on how what you do affects the site, and learn the internals later.
Successfully handles: Index, Show Check, nice check on the date to print the overdue mesage!
Successfully handles: New, Create Check
Successfully handles: Edit, Update Check, nice use of the partial view!
Successfully handles: Destroy, Task Complete Check
Routes follow RESTful conventions Check
Uses named routes (like _path) Check
Overall Note, it's convention in your HTML class attributes to name them with hyphens (-) instead of underscores (_) when using a class name with multiple words. A, "most magnificent task list." The styling looks pretty good and I like how you assigned priorities to tasks and separated their display. In the future I might use the model's where method to get 2 instance variables, one for high-priority tasks and one for low priority tasks and thus reduce the amount of logic code mixed in with the HTML in the view. I like the use of emojis for checkmarks. In the future you could also dispose of the done field in the model and just use the complete_date field to track if the task is done. Overall this was very well done, a good start for Rails!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants