Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haby's Tasklist #33

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Haby's Tasklist #33

wants to merge 21 commits into from

Conversation

habypsow
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model is connected to a table in the database, and we use the model to access this data.
Describe in your own words what the Controller is doing in Rails The controller is the central manager of the rails application, it takes requests from the server, gets information from the model and sends information to the views which then gets eventually routed back to the server.
Describe in your own words what the View is doing in Rails The view uses ERB, the file is preprocessed with ERB, and then results in an HTML file which is sent to the browser as HTML.
What is the purpose of using strong params? (i.e. the params method in the controller) Strong params are a security measure, they are a way to ensure that your users will not have the ability to access and change sensitive data.
How are Rails migrations related to Rails models? Rails migrations add the ability to model data structures and their relationships, for example the ability to add a column to a table model would be attributed to a rails migration.
Describe one area of Rails that are still unclear on whew. all the areas??

@kariabancroft
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Yes
Answered comprehension questions Yes
Successfully handles: Index, Show Yes. There was one part of these views that seemed odd, where you had an else "haha". Was that else never utilized?
Successfully handles: New, Create Yes. Note that you want to indent the pieces that are inside of the form_for helper in the view for better readability.
Successfully handles: Edit, Update Yes. Nitpick in the controller, keep the edit and update methods next to one another for easy readability. Same comment re: indentation in the edit view.
Successfully handles: Destroy, Task Complete The completion_date as a string is fine in the schema, but I think it would make more sense as a datetime type. It seems like you had this and then switch it from the datetime at some point so i'm curious why. I think this answers my question about about that else statement since it seems like it will always have some value.
Routes follow RESTful conventions Yes. It is a bit odd to have more than one route going to the same controller action (tasks#complete). Did you end up using both?
Uses named routes (like _path) Yes
Overall Nice job covering all CRUD operations. I like that you added some additional styling to the site as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants