Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashton task List #34

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Ashton task List #34

wants to merge 28 commits into from

Conversation

ashtn
Copy link

@ashtn ashtn commented Mar 27, 2017

Task List

Congratulations! You're submitting your assignment!

So I currently have a "can't automatically merge" error, so i'm hoping this works. Apologies if this doesn't. I feel like i double check before forking to make sure I'm not on ada gold, but something weird keeps happening.

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model communicated with the database to pull requested information
Describe in your own words what the Controller is doing in Rails The controller is the "project manager" it handles communication between the client, and the software.
Describe in your own words what the View is doing in Rails The view is transforming the requested information into visuals
What is the purpose of using strong params? (i.e. the params method in the controller) To ensure only the requested information is passed into the software
How are Rails migrations related to Rails models? Rails migrations are edits to rails models
Describe one area of Rails that are still unclear on if / and or how view (specifically the form inside view) is connecting or communicating to routes. On the diagram on the white board, would we have a magic line going from view to routes, or is this done through the controller? (there are tons of opinions on google)

p.s. My task list has no css.. BUT I had a ton of fun figuring out how how to make text appear conditionally on my show page, as well as adding a complete task button to the show page.

ashtn added 26 commits March 21, 2017 14:00
… individual page, created partial form and updated all froms, completed update rails cycle
@kariabancroft
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Yes
Answered comprehension questions Yes. To try to answer your final question: the form in the view has a path associated with it in the form tag: action=, and a method=. These two pieces correspond to a potential route. This route is configured in your routes file to go to a specific controller action.
Successfully handles: Index, Show Yes. Note for CSS, you do class="class-name", not class:. I like the way you've put completion logic in the index view. When you pull out model object properties, it is cleaner to use the dot notation rather than the hash notation (i.e. line 20 doing task.id rather than task[:id])
Successfully handles: New, Create Yes. Nice job using the form partial and creating a drop-down menu.
Successfully handles: Edit, Update Yes
Successfully handles: Destroy, Task Complete Yes. For task completion, you did a nice job of using the current time to set the completion status. In the future, you may be able to pass in only the boolean value and utilize that to set the time in the controller action. We try our best to exclude any important logical processing from the views.
Routes follow RESTful conventions Yes. I like the way you grouped them together.
Uses named routes (like _path) Yes
Overall Nice job! You did a nice job exploring each piece we covered in class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants