Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queues - Kayla Kubicke - js-digital-clock #15

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Queues - Kayla Kubicke - js-digital-clock #15

wants to merge 16 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2017

Digital Clock

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does jQuery give you that JavaScript doesn't? jQuery allows you to quickly and efficiently change the DOM and helps standardize how the DOM is displayed across browsers.
Describe what the following jQuery selector would give you: $('#list') $('#list') will select the id attribute 'list' within the given HTML document.
Highlight three major things you learned about JavaScript this week? Javascript is quirky. You have a lot of flexibility which is lovely, but that can easily lead to difficult bugs if you do not know what you're doing. It's best remain aware of the most recent code you've written and, if an odd bug arises, it's best to comment out everything and then slowly uncomment. Also, console.log everything.

Kayla and others added 16 commits May 19, 2017 15:05
Basic clock displays on page.
61ea902 
Basic Javascript/jQuery setup finished.
Current time and date displays on page.
Seconds change on clock.
600d2f8 
Entire clock correctly changes time based on the seconds.
Removed unnecessary code.
a2a6b13
Merge pull request #1 from moonpastry/basiclock
ae9ad4f 
Basiclock
Clock updates based on individual characteristics.
9735ef8 
Updated clock changes based on several individual characteristics.
Every second the clock updates (clock updates based on 1 second intervals).
Leading zeros are displayed for hour, minute, and second.
dbda4c0
12-hour clock displays full year.
cad742a 
am/pm is displayed based on hour of day.
Clock changed from 24-hour format to 12-hour format.
Clock displays full year.
Clock function is called before setInterval to avoid lag.
b51d8ef
Fixed hours variable.
1e218dc 
Hours is properly converted to 12-hour format.
Hours displays a leading zero if convertedHour only contains one number.
Merge pull request #2 from moonpastry/features
182e452 
Features
Basic styling.
1aabfaa
Removed extra code.
7fae34e
Refactored newTime string and time calculation.
a42d048 
Incorporated Noam's suggestions to improve readability and remove unnecessary code.
Created decideLeadingZero function to evaluate if a time element requires a
leading zero.
Merge pull request #3 from moonpastry/refactor
2d731be 
Refactor
Refactored clock to update via a DateTime object.
1cdd0c9 
Clock function creates a new DateTime object and returns the date and time via the object.
Merge pull request #4 from moonpastry/refactor
0b9a393 
Refactored clock to update via a DateTime object.
@droberts-sea
Copy link

Digital Clock

What We're Looking For

Feature Feedback
General
Uses a JavaScript function to get the time yes
Uses JavaScript to manipulate the DOM yes
Creates a custom function to handle logic yes
Overall

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@droberts-sea