Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks-Rana's trek travel #19

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

RanaSulaiman
Copy link

@RanaSulaiman RanaSulaiman commented May 30, 2017

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Means that the pieces of code are processed independently and in our project here, the script will send a request to the server and continue without waiting for the reply
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Show one trip information is executed asynchronously, I designed a template to view the information but it won’t display until the user click the trip link and trigger that event
What kind of errors might the API give you? How did you choose to handle them? For example, If the WIFI was off then AJAX will fail to get a response from API. In order to handle API error I added fail method which will display an error message to notify the user that his request was not processed.
What is an Underscore template? Describe one template you used for this project. Is a piece of code in HTML file wrapped in script tag and has two attributes, id and type. Then by using underscore template method we can generate HTML and then view it in the browser. An example of template I used is a form to reserve for a trip which will display alongside with information for one trip
Do you have any recommendations on how we could improve this project for the next cohort?

…dynamic trip list and trip infornmation are done
…cate when pessing trip link after showing trip list
filter trips by search queries is done
Moved tbody from template to table section
More styling and cleaned up the code
@RanaSulaiman RanaSulaiman changed the title Stacks-Rana's trek treavel Stacks-Rana's trek travel May 30, 2017
@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Lots of commits, good.
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check
Styling, Foundation grid layout Very nicely styled
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Well organized JS, good that you had the URL defined at the top.
HTML is semantic Not bad, but you don't have to use divs for foundation grid layout, you can use section or aside or main etc.
All dynamic content is rendered using Underscore templates Check
Overall Very nicely done and very a beautiful site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants