Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Cara Comfort - Trek #20

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

cecomfort
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? When code is asynchronous, it will be executed at some point in the future, often in response to some external event.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Every call to the API is an asynchronous event, and any code below the API call will be executed while the client waits for the server's response. Because of this, I wrote callback functions that would only be executed when the response was received. I chose to only modify the html inside these callback functions so that I could display everything that I wanted together.
What kind of errors might the API give you? How did you choose to handle them? If the API server is down, then you will not be able to load any trips or reserve a spot on a trip. When this occurs, I let you user know as well as print a more technical message to the console.
What is an Underscore template? Describe one template you used for this project. An underscore template predefines HTML that we may want to insert into an existing element at a later point in time. It is defined in HTML but invoked in JS, allowing us to separate our views from our logic. I used an underscore template to predefine the HTML I wanted to use to display a list of trips. When a user clicked the trips button, the API was called, and when a response was received, the underscore template was invoked.
Do you have any recommendations on how we could improve this project for the next cohort? Nope!

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes - good work!
Styling, Foundation grid layout yes - I really like the styling here
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic yes
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants