Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks - Jackie - Trek #25

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jackiewatanabe
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? your code doesnt have to wait for the previous statement to finish before running.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? each clickhandler holds a callback function that will not execute until that specific clickhandler is triggered first.
What kind of errors might the API give you? How did you choose to handle them? if there are errors, a message should show up in the #errors section
What is an Underscore template? Describe one template you used for this project. and underscore template is a way to use javascript code in html to dynamically create html tags and attributes. I used underscore templates to load all trips as well as by category...also to load a single trip and its reserve form.
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene You commits seem to come in big chunks, more granular commitments.
Comprehension questions The errors question had more to do with what kind of errors might an API return with. Otherwise good.
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check, but it returns, Trip reserved for undefined!
Errors are reported to the user The AJAX request returns, AJAX request failed!, nice! No errors are reported when the form fails, or when the user clicks on a trip and the network is down.
Styling, Foundation grid layout Check
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Everything broken into functions and lots minimal code in document.ready. Good work
HTML is semantic Check, good work putting the templates at the bottom of the HTML.
All dynamic content is rendered using Underscore templates Check, nicely done
Overall Nice work, this looks good and works well except for the message on submission of the form. No errors reported for other things. Otherwise nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants