Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alena's Trek #28

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Alena's Trek #28

wants to merge 13 commits into from

Conversation

Spatterjaaay
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Code that is scheduled to execute when an event happens.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? For example reservationHandler function. The code will execute that function only when an element that was specified (in this case submit button) is clicked on. Because the submit button exists in a form that is in a template, the function had to be placed in the same scope as the code that renders that template.
What kind of errors might the API give you? How did you choose to handle them? For example, if the url is wrong, the api will return an error. I have included failure callbacks to display a message that request failed.
What is an Underscore template? Describe one template you used for this project. Undescore is a JavaScript library. It gives us similar functionality as ERB in Rails. It generates html content and allows us to use data from the js file. I used the template for generating the list of trips and then to display the individual trip info and a reservation form.
Do you have any recommendations on how we could improve this project for the next cohort? Nope. I thought it was a very good project introducing various new concepts, such as Ajax and Underscore that was made us do our own research while providing enough information to get us started. It was a lot of fun!

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits, good messages, despite some spelling errors :O
Comprehension questions Check, glad you enjoyed it!
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check, good and visible error messages, I like the separate div sections for messaging.
Styling, Foundation grid layout Check, nice work, I like the background.
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Check
HTML is semantic Check
All dynamic content is rendered using Underscore templates Check, well done
Overall You hit all the requirement, I like the styling. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants