Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addie's Trek #29

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Addie's Trek #29

wants to merge 22 commits into from

Conversation

add2point71dots
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that it can execute at (essentially) any time. I could define a function and not know exactly when it's going to run (due perhaps to user interaction -- as opposed to calling it directly within the flow of my program).
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? When the user clicks the 'All trips' button, all the trips load. This means that in my document.ready, I have defined a piece of code that's waiting for the user to click on that particular button. When the user clicks, it then calls my tripListClickHandler, which in turn calls other functions that will load the trips to the page.
What kind of errors might the API give you? How did you choose to handle them? If the internet is out/slow, or if the url is incorrect, the user will get an error message saying that there was an error, and I logged an error message to the console, as well.
What is an Underscore template? Describe one template you used for this project. It's a template of html with javascript variables mixed in (similar to a .html.erb file in ruby) so we can dynamically fill in data to be uniformly displayed, drying up our html. I had a template for a trip details page, which included the details for a particular trip, along with a form to reserve that trip.
Do you have any recommendations on how we could improve this project for the next cohort? Nothing in particular!

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Lots of commits and good messages
Comprehension questions Check, nicely done.
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check, nice error messages, the red is easy to read.
Styling, Foundation grid layout Foundation grid layout, good styling
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Check
HTML is semantic Check, clean & easy to read
All dynamic content is rendered using Underscore templates Check
Budget Trips Nice new functionality
Creating New Trips Nice add-in
Overall Very nicely done with optional functionality. Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants