Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Tamiko Terada - trek #30

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

TamikoT
Copy link

@TamikoT TamikoT commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for the code to be asynchronous? It means that the code is NOT executed from top to bottom. With this single-page Javascript app, I wrote asynchronous code in the form of event handlers that "listened" for specific actions by the user. This code would only be executed when the event is triggered and would run asynchronously.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The "New Trips" functionality is run asynchronously. I create a form with an underscore template for the user to fill in but do not display the form until the user clicks the "Add a Trip" button. I put the code for the form outside of the $(document)ready and the event handler inside because the HTML element needs to exist before the event can be listened for.
What kind of errors might the API give you? How did you choose to handle them? The API can give me errors as problematic HTTP status codes or as "null" for a GET request. I handled any errors from an AJAX function with a failure-case callback.
What is an Underscore template? Describe one template you used for this project. Underscore is a useful Javascript library for adding templates into a project. I created a template to show each of the trips when the user clicks "All Trips".
Do you have any recommendations on how we could improve this project for the next cohort?

@PilgrimMemoirs
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well done
Comprehension questions Well Done
Functionality
Click a button to list trips Well Done
Click a trip to see trip details Well Done
Fill out a form to reserve a spot Well Done
Errors are reported to the user Well Done - Most users probably don't know what an AJAX call is, so the browser displayed error is best left more vague.
Styling, Foundation grid layout Well Done - Looks great!
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read Well Done
HTML is semantic Well Done - Really Well Organized
All dynamic content is rendered using Underscore templates Well Done - Really Well Organized
Overall
Great work completing the requirements and optionals. The submission meets the expectations and learning goals for this project. Great work creating a really well designed and easy to use frontend layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants