Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Allison Northrop - Trek #34

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Allison-Northrop
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means the code doesn't necessarily execute in a synchronous (step by step/top down) way. Asynchronous programming is event driven.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? If I'm not mistaken, the api call only happens when the user clicks the name of the trip. Instead of calling the api immediately when the page loads, it waits until an event happens (someone clicks the name) and then it will call to the api.
What kind of errors might the API give you? How did you choose to handle them? The api could potentially be down, so that would be an error. It's best to handle errors by flashing them on the screen when it happens
What is an Underscore template? Describe one template you used for this project. An underscore template is a piece of html code that is executed once a particular thing happens. For example, in my project, I have a template for the extended trip details. The template/information in the template doesn't show until the title of the trip is clicked. Once it's clicked the template pops up with the information.
Do you have any recommendations on how we could improve this project for the next cohort? I think dealing with the slide down toggle situation distracted me from what I should have been concentrating on (the api calls and the error handling)

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes - good definition of "asynchronous"
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user no - AJAX calls have the potential to fail, so you should attempt to report errors to the user in a friendly and actionable manner.
Styling, Foundation grid layout yes
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic yes
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants