Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues- Janice Lichtman - Trek #37

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Queues- Janice Lichtman - Trek #37

wants to merge 16 commits into from

Conversation

J-C-L
Copy link

@J-C-L J-C-L commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that code does not necessarily execute in a strictly linear manner. In particular, code may wait for a specific event to happen before executing. Also, further lines of code may continue to execute while other code is waiting for a response from a user of server.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Every call to an API is an asynchronous event. I therefor put all my functional behavior in my callback functions rather than in my click handlers, so that the code would wait for the response before executing.
What kind of errors might the API give you? How did you choose to handle them? We might have an error if the API was down. I added failure callback functions to my API calls that would politely tell the user their request could not be met, and simultaneously log the problem in the console.
What is an Underscore template? Describe one template you used for this project. Underscore templates are blocks of HTML code whose outlines are set up initially, but which are populated with data dynamically using javascript. I used HTML templates whenever I wanted to display data that I would receive from an API, such as a list of available trips, or the details for a particular trip.
Do you have any recommendations on how we could improve this project for the next cohort? The lecture and exercise about organizing your javascript code could be done earlier in the week, so students could keep those ideas in mind as they worked on the project.

|

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes
Styling, Foundation grid layout yes - wonderful look and feel, great work!
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic some - there are a few places <div> is used where <section> or <aside> might be more meaningful
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants