Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kelly Souza Trek #38

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Kelly Souza Trek #38

wants to merge 9 commits into from

Conversation

kellysouza
Copy link

@kellysouza kellysouza commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It doesn't load in order line by line
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I was having issues with the api calls not working properly. I realized because I was defining the url then setting it in each of the click handlers, it was sometimes calling the wrong url. I made sure to give each click handler its own url variable.
What kind of errors might the API give you? How did you choose to handle them? It could return no data or have an invalid url. I included error messages which show up if these thing occur.
What is an Underscore template? Describe one template you used for this project. Underscore templates are templates which are build in the html page them compiled and appended to an html element. I used a template for the individual trip api data.
Do you have any recommendations on how we could improve this project for the next cohort? No

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Check
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check Ajax error reported. Probably should be a nicer end-user message however.
Styling, Foundation grid layout Very nice styling it looks great!
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Pretty well organized and minimal code in document.ready.
HTML is semantic Check
All dynamic content is rendered using Underscore templates Check
Overall Very nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants