Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Anna Barklund - Trek #41

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Queues - Anna Barklund - Trek #41

wants to merge 16 commits into from

Conversation

amb54
Copy link

@amb54 amb54 commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? One can do many things at the same time. One can interact with a webpage while waiting for a response.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The clickHandlers in combination with the callback functions.
What kind of errors might the API give you? How did you choose to handle them? I used theJQuery method .fail on the AJAX request.
What is an Underscore template? Describe one template you used for this project. The template is defined in the html file and compiled and used in the javascript file. I used a template for viewing information of a specific trip.
Do you have any recommendations on how we could improve this project for the next cohort? I liked this project. It would be great if one could make a query with multiple parameters. For example to find a trip with budget 500 in Africa for 2 weeks (Maybe one can already do this, and I just did not figure out how.)

amb54 added 16 commits May 24, 2017 10:09
…l with src scripts placed in head for jquery, ajax/underscore and the index.js file. Inindex.js created the functions successCallbackList, failureCallback, clickHandlerList. In index.js created the variable urlBasic and also the .ready() block.
…tatic part. Updated the table in the static part with id = view list. Updated the script#list_template button with the attribute data-tripid.
…p button. Subsequently created the functions clickHandlerTrip and successCallbackTrip. Created a function showPage to handle what parts to show at an event. Subsequently updated the functions successCallbackList and successCallbackTrip.
…ion. In the index.html file updated the buttons with class = button. Added rule for .button in the index.css file.
…emplate. Added link to continent in the list_template as well as in the trip_tamplete. Some minor cosmetic changes.
…handling sorting the list of trips. Added click events (one for sort and two for query) in the .ready block. Created the helper functions sortNumbers, sortStrings, toggleAsc and resetAscending. Updated the successCallbackList function to handle sort. Added two clickHanndlers (clickHandlerSort and clickHandlerQuery) and updated the clickHandlerList function.
@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user no - You log to the console, but nothing appears on the page. I do see you've got some jquery code to add an error to the page, but it targets an ID (#errors) that isn't in your HTML.
Styling, Foundation grid layout yes
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes - very nice
HTML is semantic yes - good organization, with templates at the bottom under a big comment
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants