Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Marisol Lopez - Trek #42

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

marisol-lopez
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that content loads dynamically.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Showing the individual trip details loads asynchronously. Once the user loads all trips, they can click on an individual trip and view its details without reloading the page.
What kind of errors might the API give you? How did you choose to handle them? If it was unavailable or if there were no trips. I have an error that will let the user know if they've made a bad request.
What is an Underscore template? Describe one template you used for this project. Underscore is a way to produce templates in your HTML using javascript and Jquery. That way you can access the data without having to put the logic in your html and without putting HTML in your javascript.
Do you have any recommendations on how we could improve this project for the next cohort? Be more explicit about the dropdown portion, so that they know they don't have to go and figure out modal or toggleSlide and get bogged down on that when they should be primarily focus on getting underscore and jquery to work to read and display the api information.

@PilgrimMemoirs
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene
Comprehension questions Mostly Good - expand on 'loads dynamically' for the first question (https://stackoverflow.com/questions/3393751/what-does-asynchronous-means-in-ajax)
Functionality
Click a button to list trips Well Done
Click a trip to see trip details Well done
Fill out a form to reserve a spot Well Done
Errors are reported to the user Well Done
Styling, Foundation grid layout Well Done - nice use of block grid
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read Well Done
HTML is semantic Okay - Should still be using semantic sectioning tags like <header> and <main>
All dynamic content is rendered using Underscore templates Well Done
Overall
Great work on all the requirements. Submission meets our expectations the project's learning goals. Continue to work on using semantic sectioning tags in your HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants