You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that xz just happened, I want to minimize Porcupine's dependencies, and I think toposort is the only dependency that can be reasonably removed.
When I added toposort dependency in 2017 (commit c713798), it was because I couldn't figure out how to program it myself. The source code is short, but it looked complicated and I didn't want to copy it. Since then, I have worked with graphs more and the algorithm is now quite obvious to me, so I rewrote it from scratch.
Good question. It can be removed, but it would require a few hours of Windows hell.
Porcupine only uses user_log_path, user_cache_path and user_config_path. Determining them on 3 different platforms gives 9 different cases. It would be slightly more work than this PR, but maybe worth the effort.
As for the windows hell: In platformdirs source code, they have 3 ways to locate folders (ctypes, registry, environment variables). They dynamically pick whatever works when platformdirs is imported. Environment variables are by far the simplest way, and probably reliable enough for Porcupine, but this needs to be tested in a few different Windows environments to convince me.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that xz just happened, I want to minimize Porcupine's dependencies, and I think
toposortis the only dependency that can be reasonably removed.When I added
toposortdependency in 2017 (commit c713798), it was because I couldn't figure out how to program it myself. The source code is short, but it looked complicated and I didn't want to copy it. Since then, I have worked with graphs more and the algorithm is now quite obvious to me, so I rewrote it from scratch.