chan_simpleusb / chan_usbradio: Modify cos operation #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chan_simpleusb and chan_usbradio should not activate the receiver when the carrierfrom and ctcssfrom are set to no. This closes #329.
mkmer
reviewed
Jul 16, 2024
| @@ -2260,6 +2260,13 @@ static struct ast_frame *simpleusb_read(struct ast_channel *c) | |||
| sd = 1; | |||
| } | |||
| o->rx_ctcss_active = sd; | |||
There was a problem hiding this comment.
Shouldn't this assignment follow the new code?
o->rx_ctcss_active = sd will not be changed (or maybe that's what you wanted?)
There was a problem hiding this comment.
I left that so that the live display would show the actual signal being received. We may have a cos activation and that would be displayed, however, if the options are set to 'no', the ptt would not be keyed.
Setting both options to 'no' is a real unique situation. It would be a case where the device can only transmit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chan_simpleusb and chan_usbradio should not activate the receiver
when the carrierfrom and ctcssfrom are set to no.
This closes #329.