Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_rpt: Update to use DNS SRV record #361

Merged
merged 4 commits into from
Jul 16, 2024
Merged

app_rpt: Update to use DNS SRV record #361

merged 4 commits into from
Jul 16, 2024

Conversation

KB4MDD
Copy link
Collaborator

@KB4MDD KB4MDD commented Jul 15, 2024

This updates app_rpt to use DNS SRV records when looking up a node by DNS.

The original code used the TXT record which was labeled for debugging purposes. The original TXT lookup code remains and is switched off for now.

This closes #360

This updates app_rpt to use DNS SRV records when looking up a node by DNS.

The original code used the TXT record which was labeled for debugging purposes.  The original TXT lookup code remains and is switched off for now.

This closes #360
@KB4MDD KB4MDD requested a review from InterLinked1 July 15, 2024 18:58
@KB4MDD KB4MDD self-assigned this Jul 15, 2024
apps/app_rpt/rpt_config.c Show resolved Hide resolved
apps/app_rpt/rpt_config.c Outdated Show resolved Hide resolved
This updates app_rpt to use DNS SRV records when looking up a node by DNS.

The original code used the TXT record which was labeled for debugging purposes. The original TXT lookup code remains and is switched off for now.

This closes #360
This updates app_rpt to use DNS SRV records when looking up a node by DNS.

The original code used the TXT record which was labeled for debugging purposes. The original TXT lookup code remains and is switched off for now.

This closes #360
Copy link
Collaborator

@Allan-N Allan-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This updates app_rpt to use DNS SRV records when looking up a node by DNS.

The original code used the TXT record which was labeled for debugging purposes. The original TXT lookup code remains and is switched off for now.

This closes #360
@Allan-N Allan-N merged commit 10ddc8c into master Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct ASL DNS Node Address Resolution
2 participants