Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow faster morse speed. #368

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Allow faster morse speed. #368

merged 1 commit into from
Jul 24, 2024

Conversation

JimZAH
Copy link
Contributor

@JimZAH JimZAH commented Jul 21, 2024

Fixes #367
Increase the max limit to 35wpm.

Copy link
Member

@tsawyer tsawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllStar is built in the US where part 97 FCC rules limit CW ID to 20wpm. Somebody way back when thought "enforcing" 20wpm was a good idea. It wasn't. ASL has no responsibility to insure radio systems are operated in accordance with local regulations and should not imply so by setting a 20wpm CW speed limit.

I like to know why is 35 the requested limit?

@JimZAH
Copy link
Contributor Author

JimZAH commented Jul 21, 2024 via email

@tsawyer tsawyer mentioned this pull request Jul 21, 2024
@tsawyer tsawyer removed the request for review from InterLinked1 July 21, 2024 23:03
Copy link
Collaborator

@Allan-N Allan-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@tsawyer tsawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@Allan-N
Copy link
Collaborator

Allan-N commented Jul 24, 2024

Let's merge this.

BEFORE merging we NEED to ensure that this change won't impact existing configs.

@tsawyer tsawyer merged commit 83061db into AllStarLink:master Jul 24, 2024
1 check passed
@KB4MDD
Copy link
Collaborator

KB4MDD commented Jul 24, 2024

If someone has a speed faster than 20wpm defined, after the merge it will go up to the amount set or capped at 35.

@JimZAH
Copy link
Contributor Author

JimZAH commented Jul 24, 2024

It should stay the same (whatever it's currently set at). If they've set it at 30 it will go up to 30. The limit is 35.

@Allan-N
Copy link
Collaborator

Allan-N commented Jul 24, 2024

My apologies. I was thinking that this was [another] rpt.conf change. Yes, this change was fine to merge.

@Allan-N
Copy link
Collaborator

Allan-N commented Aug 2, 2024

The fix for this issue has been incorporated into ASL3-Asterisk 20.9.1+asl3-3.0.4-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow faster morse
4 participants