Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSettings Implementation #2949

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

keval-finimble
Copy link
Contributor

  • Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
  • Added other fields in the json and call them directly from the json file in CustomSettings.

Keval Shukla added 2 commits November 15, 2022 16:54
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
14
▀▀▀▀
3h 36m
10
▀▀▀▀▀▀▀▀
JamesSmartCell
🥈
11
▀▀▀
1d 41m
▀▀▀▀
2
▀▀
justindg
🥉
8
▀▀
1d 5h 2m
▀▀▀▀▀
1

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 7.62% // Head: 7.68% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (41c7a3e) compared to base (7784baa).
Patch coverage: 8.08% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2949      +/-   ##
===========================================
+ Coverage      7.62%   7.68%   +0.05%     
- Complexity      836     856      +20     
===========================================
  Files           612     639      +27     
  Lines         41863   42918    +1055     
  Branches       4226    4310      +84     
===========================================
+ Hits           3194    3300     +106     
- Misses        38395   39346     +951     
+ Partials        274     272       -2     
Impacted Files Coverage Δ
app/src/main/java/com/alphawallet/app/App.java 0.00% <0.00%> (ø)
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...m/alphawallet/app/entity/ActionSheetInterface.java 0.00% <0.00%> (ø)
...ain/java/com/alphawallet/app/entity/EventSync.java 0.00% <0.00%> (ø)
...awallet/app/entity/SignAuthenticationCallback.java 0.00% <ø> (ø)
...c/main/java/com/alphawallet/app/entity/Wallet.java 0.00% <0.00%> (ø)
...com/alphawallet/app/entity/tokens/ERC721Token.java 0.00% <0.00%> (ø)
...llet/app/entity/walletconnect/NamespaceParser.java 0.00% <0.00%> (ø)
...entity/walletconnect/WalletConnectSessionItem.java 0.00% <0.00%> (ø)
...tity/walletconnect/WalletConnectV2SessionItem.java 0.00% <0.00%> (ø)
... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Keval Shukla added 8 commits November 16, 2022 19:35
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
… into 2758-feature-customisation-json

# Conflicts:
#	app/src/main/java/com/alphawallet/app/service/PriceAlertsService.java
#	app/src/main/java/com/alphawallet/app/viewmodel/WalletViewModel.java
Keval Shukla added 10 commits November 22, 2022 19:52
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
…ectly from Activity and Fragments.

- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
… into 2758-feature-customisation-json

# Conflicts:
#	app/src/main/java/com/alphawallet/app/service/PriceAlertsService.java
#	app/src/main/java/com/alphawallet/app/ui/AssetDisplayActivity.java
#	app/src/main/java/com/alphawallet/app/ui/HomeActivity.java
#	app/src/main/java/com/alphawallet/app/ui/NFTAssetsFragment.java
#	app/src/main/java/com/alphawallet/app/ui/widget/adapter/NonFungibleTokenAdapter.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant