github actions update (MiczFlor#2240)

* Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/[email protected])

* Bump geekyeggo/delete-artifact from 2 to 4

* add write permission for artifact deletion

* ignore fails for artifact deletion

* REVERT: 
ignore fails for artifact deletion

* REVERT: 
add write permission for artifact deletion

* remove cleanup stage for now

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/test_docker_debian_codename_sub.yml

@@ -128,7 +128,7 @@ jobs:
           BASE_TEST_IMAGE=${{ steps.vars.outputs.image_tag_name_local_base }}
 
     - name: Artifact Upload Docker Image
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ steps.vars.outputs.image_file_name }}
         path: ${{ steps.vars.outputs.image_file_path }}
@@ -158,7 +158,7 @@ jobs:
       uses: docker/[email protected]
 
     - name: Artifact Download Docker Image
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ${{ needs.build.outputs.image_file_name }}
 
@@ -176,15 +176,15 @@ jobs:
         args: |
           ./${{ matrix.test_script }}
 
-  # cleanup after test execution
-  cleanup:
-    # run only if tests didn't fail: keep the artifact to make job reruns possible
-    if: ${{ !failure() }}
-    needs: [build, test]
-    runs-on: ${{ inputs.runs_on }}
-
-    steps:
-        - name: Artifact Delete Docker Image
-          uses: geekyeggo/delete-artifact@v2
-          with:
-            name: ${{ needs.build.outputs.image_file_name }}
+  ## cleanup after test execution
+  # cleanup:
+    ## run only if tests didn't fail: keep the artifact to make job reruns possible
+    #if: ${{ !failure() }}
+    #needs: [build, test]
+    #runs-on: ${{ inputs.runs_on }}
+    #
+    #steps:
+    #    - name: Artifact Delete Docker Image
+    #      uses: geekyeggo/delete-artifact@v4
+    #      with:
+    #        name: ${{ needs.build.outputs.image_file_name }}