Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/components demo #94

Merged
merged 21 commits into from
Jan 12, 2022
Merged

Feature/components demo #94

merged 21 commits into from
Jan 12, 2022

Conversation

sparklestheunicorn
Copy link
Collaborator

@sparklestheunicorn sparklestheunicorn commented Oct 23, 2021

This PR is the first example of styling components in line with issue #93. It adds a checkbox and button-bar-style radio buttons.

If you will be visually styling components per the Manhattan Hydraulics mock-ups, this is a good example. Check out the changes in:

  • components/radioButtons.tsx - Shows how to apply a treatment prop to a UI component to give it a particular treatment
  • styles/radio-buttons.js - Shows how to write WindiCSS shortcuts to create general shared styles. Styles specific to a particular component should be added as classes to that component's className prop (See checkbox.tsx - notice that the CSS module is sparse, providing only styling not currently supported by WindiCSS).
  • windi.config.ts - Adds the shortcut so that it can be applied globally

Other changes:

  • Add a component demo page
  • Adds props to existing UI components
  • Adds a checkbox component
  • Adds support for importing SVGs for next/image

@vercel
Copy link

vercel bot commented Oct 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blacksocialists/dual-power-app/761BJABLMMEc1hKY7KHnycRwXYk2
✅ Preview: https://dual-power-app-git-feature-components-demo-blacksocialists.vercel.app

@replygirl
Copy link
Contributor

replygirl commented Oct 23, 2021

components/checkbox.tsx Outdated Show resolved Hide resolved
components/checkbox.tsx Outdated Show resolved Hide resolved
components/radioButtons.tsx Outdated Show resolved Hide resolved
components/radioButtons.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
components/checkbox.module.css Outdated Show resolved Hide resolved
components/checkbox.module.css Outdated Show resolved Hide resolved
components/checkbox.module.css Outdated Show resolved Hide resolved
components/checkbox.module.css Outdated Show resolved Hide resolved
windi.config.ts Outdated Show resolved Hide resolved
@jackhajb
Copy link
Collaborator

@mis4mike On focus I'm noticing the components all get a blue outline. Think we should override.

image

components/checkbox.tsx Outdated Show resolved Hide resolved
@replygirl
Copy link
Contributor

@sparklestheunicorn
Copy link
Collaborator Author

@replygirl does this PR reflect all your changes, and if so, is it ready to merge? The code and Vercel environment look good to me, but Github seems to think there's a pending change request somewhere that I can't find.

@replygirl
Copy link
Contributor

@mis4mike On focus I'm noticing the components all get a blue outline. Think we should override.

image

I added a focus-ring shortcut class that will handle this for us :)

@replygirl
Copy link
Contributor

I approve of my own changes lol

@replygirl replygirl enabled auto-merge (squash) January 12, 2022 21:00
@replygirl replygirl merged commit e30982b into main Jan 12, 2022
@replygirl replygirl deleted the feature/components-demo branch January 12, 2022 21:01
@cedrycm cedrycm mentioned this pull request Jan 13, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants