Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safely handle duplicate entries when punishing alts #994

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

confuser
Copy link
Member

@confuser confuser commented Sep 8, 2024

Reported on Discord:

[<t:1724562463:T> INFO] player1 lost connection: Disconnected
[<t:1724562463:T> INFO] Warning: player1 has the same IP as the following players:
player2
[<t:1724562463:T> WARN] java.sql.SQLException: Unable to run insert stmt on object me.confuser.banmanager.common.data.PlayerBanData@59b3f364: INSERT INTO `bm_player_bans` (`player_id` ,`reason` ,`actor_id` ,`created` ,`updated` ,`expires` ,`silent` ) VALUES (?,?,?,?,?,?,?)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.ormlite.misc.SqlExceptionUtil.create(SqlExceptionUtil.java:25)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.ormlite.stmt.mapped.MappedCreate.insert(MappedCreate.java:138)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.ormlite.stmt.StatementExecutor.create(StatementExecutor.java:458)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.ormlite.dao.BaseDaoImpl.create(BaseDaoImpl.java:329)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.storage.PlayerBanStorage.ban(PlayerBanStorage.java:206)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.listeners.CommonJoinListener.punishAlts(CommonJoinListener.java:544)
[<t:1724562463:T> WARN] at BanManagerBukkit.jar//me.confuser.banmanager.common.listeners.CommonJoinListener.lambda$onPlayerLogin$1(CommonJoinListener.java:409)
[<t:1724562463:T> WARN] at org.bukkit.craftbukkit.v1_19_R2.scheduler.CraftTask.run(CraftTask.java:101)
[<t:1724562463:T> WARN] at org.bukkit.craftbukkit.v1_19_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57)
[<t:1724562463:T> WARN] at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22)
[<t:1724562463:T> WARN] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)

Issue is caused by punishAlts being triggered both on BungeeCord and Bukkit

@confuser confuser merged commit 1a73048 into master Sep 8, 2024
3 of 4 checks passed
@confuser confuser deleted the fix/punish-alt-duplication branch September 8, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant