Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritance wallet - Chapter 3 - Wallet backup #1102

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

rabbitholiness
Copy link
Collaborator

@rabbitholiness rabbitholiness commented Jul 9, 2024

This PR adds a page about how the wallet is backed up and how the material is distributed.

👀 Preview link 👀

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit de8a911
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/66ed79480a5caf0008675289
😎 Deploy Preview https://deploy-preview-1102--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Added cosigner onboarding page
- Added images
- Removed icons on the landing page, as they are not really helpful.
- Updated the chapters on the landing page to reflect the final structure.
- Updated editor's notes
- Minor text changes.
@rabbitholiness rabbitholiness force-pushed the inheritance-wallet-3-wallet-backup branch from 70b74d4 to d2a0165 Compare July 10, 2024 11:01
@rabbitholiness rabbitholiness force-pushed the inheritance-wallet-3-wallet-backup branch from d2a0165 to 7a67bf6 Compare July 18, 2024 04:36
@rabbitholiness rabbitholiness marked this pull request as ready for review July 18, 2024 04:53
@mouxdesign
Copy link
Collaborator

Adding in a review on this one as well. Similar to the previous review zooming out a bit on the content a higher level overview zoomed out would help the content to be easier to chunk in the readers mind. There seem to be 8 larger steps here and then 2 larger buckets. Will dive in more:

8 larger steps

Step 1: Initiate Backup

App prompts user to download the wallet backup kit

Step 2: Generate Backup Kit (this is titled "what is a backup kit", if rephrased it could be separated into one district step where the kit is generated)

Wallet creates a ZIP file containing:
a. PDF with wallet descriptor and XPUB information
b. Visual representation of recovery rules
c. Wallet backup files in various formats

Step 3: Download Backup Kit

User saves the backup kit to their device

Step 4: Secure Backup Kit

User encrypts the ZIP file with a strong password

Step 5: Store Primary Copies

Users (e.g., Alice and Bob) store copies in their personal password managers

Step 6: Distribute Backup Components (possible options)

  • Store encrypted backup kit with lawyer
  • Store password in bank deposit box
  • Place backup materials in home safe (USB drive, printout of will and recovery PDF)
  • Store safe PIN in shared family password manager

Step 7: Set Up Secondary Access

  • Provide children (heirs) with information on accessing home safe
  • Inform children about the assisted route through lawyer and bank

Step 8: Maintain Backups

Regularly verify and update backups as needed

More high level

Then these are further separated into actions that are happening in the interface and things that are happening offline. For the online interactions with the interface these might be good to clarify to the person reading the content.

UI - interactive

Steps 1-4

Offline (mostly)

Steps 5-8

A diagram might help to visualize this for a reader so they can zoom out and understand the content at a higher level and connect how each main section fits into each other.

Summary

These steps could be shown as one high level diagram and then there are two color sections (one color is showing online activities and the other is showing offline activities).

This would be relevant for a UX designer looking at this page so that they understand what they design and what is educational

- Added a short process overview and diagram to the wallet creation page.
- Updated the conclusion for clarity
- Minor text changes
@rabbitholiness rabbitholiness force-pushed the inheritance-wallet-3-wallet-backup branch from 1848a37 to 106bbd6 Compare August 15, 2024 10:03
@rabbitholiness
Copy link
Collaborator Author

This is a major update. It contains the following main changes:

  • Addressed @mouxdesign feedback regarding structure and readability. Thanks very much for the thorough feedback 🙏🏻.
  • More concise breakdown of the individual components of the backup scheme.
  • Added peivacy and security considerations.
  • Added recovery scenarios
  • Created mobile optimized images for the diagrams

Still to do:

  • Optimize images (dimensions, size, etc.)
  • Remove unused images from repo
  • Alt texts

Questions:
The page is quite long. Maybe the first section (what needs to be backed up) could be part of the Bitcoin Backups page and I could only reference it here.

@danielnordh
Copy link
Contributor

Questions: The page is quite long. Maybe the first section (what needs to be backed up) could be part of the Bitcoin Backups page and I could only reference it here.

I think you can cut the paragraphs called 'Private keys' and 'Wallet configuration' as they don't add much more than what is already said above in the bullet list and illustration.

I left a bunch of small comments throughout (for some reason I couldn't directly suggest code changes on this PR).

Style comments:

  • Sentence case everything (Assisted inheritance), lots of title case (Assisted Inheritance)
  • Lists should not end with punctuation

@rabbitholiness rabbitholiness force-pushed the inheritance-wallet-3-wallet-backup branch from bf182cd to 9096f8c Compare September 20, 2024 08:41
- Revised content structure
- Eliminated lots of typos
- Minor image tweaks
- Worked on clarity of expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🏗️
Development

Successfully merging this pull request may close these issues.

3 participants