Upstreaming budgie-trash-applet #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Speaking of translations, I entirely forgot to write that code before making the PR. Derp. |
|
CI failed—you're linking against a system header for popover.h instead of the one in the source tree. |
Derp, another thing I overlooked. |
EbonJaeger
force-pushed
the
upstreaming-trash-applet
branch
from
1e79dfc
to
f509c83
Compare
Signed-off-by: Evan Maddock <[email protected]>
Also renames some files to avoid conflicts. Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
… drives I went to all the trouble to store a consistent and correct URI for each trash item just to not use it. Derp. Signed-off-by: Evan Maddock <[email protected]>
JoshStrobl
force-pushed
the
upstreaming-trash-applet
branch
from
42deb0b
to
04d87a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves my Budgie Trash Applet into the Budgie Desktop source tree.
As a part of this, the applet has been redesigned and rearchitected to better fit within Budgie Desktop:
In addition to the visual changes, some of the UX have been changed. The restore button no longer just restores all items in the trash; it only restores selected items. This makes it easier to restore just one file, or to quickly restore several files at once.
Also, applet settings have been changed to be per-instance, so different instances of the applet on your panels will all have their own settings, just in case you actually want that.
Lastly, upstreaming the applet more easily allows the applet to be translated into all the wonderful languages spoken by our community. Thank you, translators, for your valuable contributions! :)
Ref #28
Submitter Checklist
git rebase -i(if needed)