Prevent notifs and scrshot from locking up when sink is locked #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshStrobl
force-pushed
the
380-screenshots-and-notifications-fail-when-audio-sink-is-locked
branch
from
0dac881
to
e47fe3a
Compare
JoshStrobl
deleted the
380-screenshots-and-notifications-fail-when-audio-sink-is-locked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two cases are handled differently, as screenshots use gstreamer and notifs use canberra.
The screenshot sound now has a timeout of 2 seconds, after which it will cancel the attempt to play the sound and just move forward with the screenshot. This may cut off longer screenshot sounds, but it doesn't cut off the default.
The notif sounds are now launched as threads, so they don't block the main thread when queued up. This means that all buffered notif sounds will play upon the default sink being unlocked, but this is how all other sound players work, so it's not a big deal.
Submitter Checklist
git rebase -i(if needed)