Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dark theme switch apply to color scheme pref #444

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Make dark theme switch apply to color scheme pref #444

merged 1 commit into from
Sep 5, 2023

Conversation

serebit
Copy link
Member

@serebit serebit commented Sep 4, 2023 •
edited
Loading

Description

Adds a few LoC into the daemon that synchronize the dark theme dconf setting with GNOME's freedesktop color scheme dconf setting.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@serebit serebit added enhancement New feature or request accepted Accepted enhancement. labels Sep 4, 2023
@serebit serebit added this to the 10.8.1 milestone Sep 4, 2023
JoshStrobl
JoshStrobl approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoshStrobl JoshStrobl merged commit f3e4d21 into main Sep 5, 2023
1 check passed
@JoshStrobl JoshStrobl deleted the color-scheme-preference branch September 5, 2023 05:06
@serebit serebit mentioned this pull request Sep 8, 2023
Closed
@EbonJaeger EbonJaeger mentioned this pull request Sep 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshStrobl JoshStrobl JoshStrobl approved these changes

Assignees
No one assigned
Labels
accepted Accepted enhancement. enhancement New feature or request
Projects
Budgie 10
Status: Done
Milestone
10.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@serebit @JoshStrobl