Fix heap buffer overflow in UsageMonitor #484
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serebit
force-pushed
the
fix-heap-buffer-overflow
branch
from
dc4746e
to
93c4122
Compare
|
How portable is this? It looks like it's an extension done by GNU C, and I don't see any documentation, at least for OpenBSD that supports |
|
Hm... It's not portable. I'll need to figure out how to preallocate the required space, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
%msformat specifier, when passed to POSIX scanf, allocates the necessary space for the value that it reads into a char**.Submitter Checklist
git rebase -i(if needed)