Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workspace applet window icon click not performing workspace switch #525

Conversation

JoshStrobl
Copy link
Member

Removed unnecessary (and borked) check. Should have been !== but not really needed anyways. It won't do anything if the window is already active on the current workspace, so the entire check is extraneous.

@JoshStrobl JoshStrobl added this to the 10.9.2 milestone Feb 3, 2024
@JoshStrobl JoshStrobl requested a review from a team February 3, 2024 19:07
@JoshStrobl JoshStrobl self-assigned this Feb 3, 2024
@JoshStrobl JoshStrobl force-pushed the 524-workspace-applet-not-switching-workspace-and-activating-application-when-icon-clickedbug branch from d3ee9d7 to 88d7414 Compare February 3, 2024 20:03
@JoshStrobl JoshStrobl changed the title Fix: workspace applet window icon click not performing workspace switch Fix workspace applet window icon click not performing workspace switch Feb 6, 2024
@JoshStrobl JoshStrobl force-pushed the 524-workspace-applet-not-switching-workspace-and-activating-application-when-icon-clickedbug branch from 88d7414 to 8b4430b Compare February 9, 2024 07:31
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@JoshStrobl JoshStrobl merged commit 9b775d6 into main Feb 11, 2024
1 check passed
@JoshStrobl JoshStrobl deleted the 524-workspace-applet-not-switching-workspace-and-activating-application-when-icon-clickedbug branch February 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Workspace applet not switching workspace and activating application when icon clicked
2 participants