Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end session dialog blocking authentication dialog #576

Conversation

levkk
Copy link
Contributor

@levkk levkk commented May 18, 2024

Description

Fix the end session dialog blocking the authentication dialog when a password is required to shut down the computer.

The fix was to hide the shutdown dialog when the "Shutdown" button is clicked.

Screenshot

Snapshot_2024-05-18_15-22-47

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@JoshStrobl
Copy link
Member

Thanks for taking the initiative with this PR! While you're at it, could you add hide() calls to the other functions like logout, restart, and move the hide() call to the end to mirror the cancel function?

@JoshStrobl JoshStrobl self-requested a review May 26, 2024 09:12
@levkk
Copy link
Contributor Author

levkk commented Jun 3, 2024

Logout doesn't require a password prompt as far as I can tell. I added the hide() call to the restart function as well. Should be good to go.

@levkk levkk force-pushed the levkk-fix-end-session-blocking-password branch from bb0f2a6 to e22b366 Compare June 3, 2024 15:10
Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@JoshStrobl JoshStrobl merged commit cc6847e into BuddiesOfBudgie:main Jun 3, 2024
1 check passed
@JoshStrobl JoshStrobl added this to the 10.10 milestone Jun 3, 2024
@levkk levkk deleted the levkk-fix-end-session-blocking-password branch June 3, 2024 17:18
JoshStrobl pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants