Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API replacing gsd-power's use of libgnome-rr #30

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

fossfreedom
Copy link
Contributor

This patch has been adapted from https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3861 Original author Jonas Ådahl
This is required to adapt to the GNOME-47 gnome-settings-daemon updates. Without the patch gsd-power segfaults resulting with budgie exiting back to the login manager.

Marking as draft to complete testing and confirmation that there are no further commits to be incorporated from gitlab

This patch has been adapted from https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3861
Original author Jonas Ådahl
This is required to adapt to the GNOME-47 gnome-settings-daemon
updates.  Without the patch gsd-power segfaults resulting with budgie
exiting back to the login manager.
@fossfreedom fossfreedom marked this pull request as ready for review September 17, 2024 18:16
@fossfreedom fossfreedom requested a review from a team as a code owner September 17, 2024 18:16
@fossfreedom
Copy link
Contributor Author

Tested via UB 24.10 and adding the patch to the existing package.

New install with hardware that has backlight support.

No longer crashes. gnome-screensaver was correctly invoked when lock chosen or the time interval reached indicating gsd-power was functioning correctly.
Brightness control as expected.

Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for porting this over. Will get it added to Fedora's packaging of magpie.

@fossfreedom fossfreedom merged commit 022fb54 into main Sep 21, 2024
1 check passed
@EbonJaeger EbonJaeger deleted the backlight branch September 21, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants