Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Log" Scaling #1236

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix "Log" Scaling #1236

merged 3 commits into from
Aug 6, 2024

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Jul 30, 2024

Fixes/Addresses: #1233

Summary/Motivation:

Corrects unscaling formula for "Log" scaling formulation.

Changes proposed in this PR:

  • Fix "Log" unscaling formula
  • Updates tests to avoid false successes due to self.min having a value of 1 or 0

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.79%. Comparing base (691185f) to head (f7ebea5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   38.81%   38.79%   -0.03%     
==========================================
  Files         164      164              
  Lines       37048    37048              
  Branches     6153     6153              
==========================================
- Hits        14382    14371      -11     
- Misses      21528    21542      +14     
+ Partials     1138     1135       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit 0aaa024 into CCSI-Toolset:master Aug 6, 2024
31 of 32 checks passed
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants