Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MN last mile failure #15933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oslynn
Copy link
Collaborator

@oslynn oslynn commented Sep 19, 2024

This PR fixed transform to blank out PID-10 when Patient race.code = "ASKU". Since, MN can't process message with NULLFL.

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@oslynn oslynn added onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. Minnesota labels Sep 19, 2024
@oslynn oslynn self-assigned this Sep 19, 2024
@oslynn oslynn requested a review from a team as a code owner September 19, 2024 22:17
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Test Results

1 229 tests  ±0   1 225 ✅ ±0   6m 54s ⏱️ -4s
  161 suites ±0       4 💤 ±0 
  161 files   ±0       0 ❌ ±0 

Results for commit bed0e91. ± Comparison against base commit 672fa54.

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

Integration Test Results

 53 files  ±0   53 suites  ±0   27m 24s ⏱️ -3s
410 tests ±0  401 ✅ ±0  9 💤 ±0  0 ❌ ±0 
413 runs  ±0  404 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit bed0e91. ± Comparison against base commit 672fa54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minnesota onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants