Resolves issue #944 - Better filtering for invalid characters in query parameters #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iddleware to all query parameters, then wrote test
david-rocca
changed the title
david-rocca
changed the title
…vides better failure information
jdaigneau5
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #944
Summary
This PR adds middleware to all endpoints that accept query parameters to filter for the characters <, >, and "
Important Changes
Define Middleware:
src/middleware/middleware.jsUse Middleware:
src/controller/cve-id.controller/index.jssrc/controller/cve.controller/index.jssrc/controller/org.controller/index.jssrc/controller/user.controller/index.jsTest Middleware
test/unit-tests/middleware/checkForInvalidCharacters.jsTesting
Steps to manually test updated functionality, if possible
npm run test:unit-tests