Improve compatibility with kubernetes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consistent usage of echo instead of printf -> resolve problems in at least some kubernetes versions - always run an initial freshclam in the foreground before even attempting to start clamd -> it will not - surround freshclam, clamd and milter with additional checks for running process -> In my kubernetes-testings the processes did not start consistent, were sometimes trying to start overlapping and the experience was not good. TODO: this can be improved by adding additional checks whether everything is still running and restarting processes if neccessary
|
Sorry this PR slipped by me. I will try to review it soon. One comment, we'll need to make these changes to the clamav 1.1 scripts as well. And probably best to also add them to the 1.0 scripts, too. Probably not worth it for 0.105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: this can be improved by adding additional checks whether everything is still running and restarting processes if neccessary