Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with rust 1.80.0 #678

Closed
pbsds opened this issue Aug 7, 2024 · 2 comments · Fixed by #680
Closed

Does not build with rust 1.80.0 #678

pbsds opened this issue Aug 7, 2024 · 2 comments · Fixed by #680

Comments

@pbsds
Copy link
Contributor

pbsds commented Aug 7, 2024

While building pagefind_ui i get

pagefind> error[E0282]: type annotations needed for `Box<_>`
pagefind>   --> /build/pagefind-1.1.0-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
pagefind>    |
pagefind> 83 |     let items = format_items
pagefind>    |         ^^^^^
pagefind> ...
pagefind> 86 |     Ok(items.into())
pagefind>    |              ---- type must be known at this point
pagefind>    |
pagefind> help: consider giving `items` an explicit type, where the placeholders `_` are specified
pagefind>    |
pagefind> 83 |     let items: Box<_> = format_items
pagefind>    |              ++++++++
pagefind> 

Likely caused by the unfixable regression rust-lang/rust#127343 as reported by @\allysais in NixOS/nixpkgs#332957, who notes that:

Most commonly, the required fix is just to update the "time" crate.

@pbsds
Copy link
Contributor Author

pbsds commented Aug 7, 2024

This seems to be the issue that has brought down your CI

image

Link to a run: https://github.com/CloudCannon/pagefind/actions/runs/9752597405/job/26916380265?pr=653

@bglw
Copy link
Contributor

bglw commented Aug 15, 2024

Thanks @pbsds ! I've been fixing this on some other crates and hadn't made it to pagefind yet 😅 Will merge your PR shortly ❤️

@bglw bglw closed this as completed in #680 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants