Rust 1.80.0 breaks some packages

[alyssais]

Dear maintainers,

Rust 1.80.0 contains a couple of changes that break some packages: an unfixable build regression, and a warning for unrecognized cfg values that some packages treat as an error. Most commonly, the required fix is just to update the "time" crate. I've opened PRs to fix as many regressions as I can, but I can't do all of them.

1.80.0 is currently in staging-next, so will probably be in Nixpkgs master in the next 1-2 weeks. It wasn't really feasible to hold back, because packages tend to start requiring new Rust versions very soon after release, and it also didn't make a lot of sense to keep 1.79.0 as well, because many of the affected packages haven't been touched in a year or more, so there'd be no assurance we'd be able to remove it any time soon.

So, some effort will be required from you to keep your package building with 1.80.0. Usually, the process will be like this:

• Figure out what's broken. Usually, but not always, this is that the "time" crate needs to be updated.
• Get it fixed upstream, if it isn't already.
• Ask upstream to release a new version, if they haven't already.
• Update the package in Nixpkgs.

As a last resort, we can patch if we need to, but especially for packages that include a Cargo.lock in Nixpkgs, this is a pain.

I'll post the affected packages in comments, because GitHub limits how many mentions an issue body can contain.

Sorry for the inconvenience. I've lost a lot of the last week to coordinating the update, collecting broken packages, etc., but hopefully by spreading out the work from here it won't take too much of anybody else's time.

[alyssais]

• amp @sbourdeauducq amp: fix build due to rust 1.80 update; refactor #339951
• anchor @xrelkd
• bandwhich @Br1ght0ne @figsoda bandwhich: fix build by manually updating time #334824
• bpf-linker @NickCao bpf-linker: 0.9.12 -> 0.9.12-unstable-2024-07-31 #334004
• cargo-info @figsoda @matthiasbeyer cargo-info: fix build #338155
• cargo-information @eopb cargo-information: 0.6.0 -> 0.7.0 #332785
• cargo-tauri @dit7ya @happysalada cargo-tauri: 1.7.1 -> 2.0.0-rc.2 #334771
• cargo-release @figsoda @Gerschtli cargo-release: 0.25.0 -> 0.25.10 #332786
• conceal @Jedsek @kashw2 conceal: 0.4.1 -> 0.5.3 #332787
• cosmic-applets @alyssais @nyabinary cosmic-applets: unstable-2023-11-13 -> 1.0.0-alpha.1 #333015
• crabfit-api (unmaintained) crabfit-api: fix Rust 1.80.0 build regression #335472
• deepfilternet @ralismark deepfilternet: fix compilation with Rust 1.80 #334838
• dim @Misterio77 dim: fix compilation error with rust 1.80 #333227
• edge-runtime @happysalada
• espflash @matthiasbeyer espflash: 3.1.0 -> 3.1.1 #334809
• evebox @felbinger evebox: 0.17.2 -> 0.18.2 #332789
• fim-rs @fabaff fim-rs: 0.4.10 -> 0.5.0 #332942
• garage @NickCao @0x4A6F @teutat3s https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/849 garage: update time to fix build with rust 1.80 #335280
• garage_0_8 @NickCao @0x4A6F @teutat3s https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/849 garage: update time to fix build with rust 1.80 #335280
• git-gr @9999years git-gr: 1.4.1 -> 1.4.2 #333056
• gossip @msanft gossip: 0.9 -> 0.11.3 #334369
• goxlr-utility @errnoh goxlr-utility: 1.1.1 -> 1.1.1-unstable-2024-08-06 #332757
• gurk-rs @devhell Rust 1.80.0 boxdot/gurk-rs#304 gurk-rs: 0.4.3 -> 0.5.1 #340311
• lapce @Eliot00 lapce: 0.4.0 -> 0.4.1 #335522
• liana @dunxen liana: 5.0 -> 6.0 #333059
• libdeltachat @dotlambda deltachat-desktop: 1.46.1 -> 1.46.2 #332706 (comment)
• lldap @bendlas lldap: rust 1.80 compatibility #333125
• martin @sikmir martin: 0.9.1 → 0.14.2 #267315
• matrix-authentication-service @teutat3s matrix-authentication-service: 0.9.0 -> 0.10.0 #336333
• mchprs @gabriel-doriath-dohler
• mcumgr-client @otavio mcumgr-client: 0.0.4 -> 0.0.7 #332799
• meilisearch @happysalada meilisearch: fix build with rust 1.80 #337325
• mouse-actions @rgri mouse-actions: 0.4.4 -> 0.4.5 #333793
• nix-init @figsoda nix-init: 0.3.0 -> 0.3.1 #334545
• nym (unmaintained)
• openobserve @happysalada openobserve: 0.10.1 -> 0.11.0 #340079
• pagefind @pbsds pagefind: update time crate, unbreak #334635
• pods @figsoda pods: 2.0.0 -> 2.0.1-unstable-2024-08-11 #335565
• polkadot @akru @andresilva @FlorianFranzen @RaghavSood polkadot: fix compilation with rust 1.80 #334414
• prisma-engines @pimeys @tomhoule @aqrln {prisma,prisma-engines}: 5.16.1 -> 5.18.0 #337521
• quickwit @happysalada
• refinery-cli @lucperkins
• replibyte @dit7ya
• ripasso-cursive @stigtsp ripasso-cursive: 0.6.4 -> 0.7.0 #340335
• roon-tui @MichaelCDormann roon-tui: 0.3.0 -> 0.3.2 #338442
• rtz @figsoda rtz: 0.5.3 -> 0.7.0 #337471
• rustdesk @ocfox @Leixb rustdesk: 1.2.3 -> 1.3.0 #337324
• rustup @Mic92 rustup: 1.26.0 -> 1.27.1 #332809
• silicon @evanjs @0x4A6F silicon: patch Cargo.lock for Rust 1.80 #337499
• sqld @dit7ya sqld: 0.17.2 -> 0.24.18 #336887
• svix-server @techknowlogick svix-server: 1.13.0 -> 1.28.0 #331866
• symbolicator @figsoda symbolicator: 23.11.2 -> 24.7.1 #332811

[alyssais]

• tectonic-unwrapped @lluchs @doronbehar @bryango (upstream issue: rust 1.80.0 build issue tectonic-typesetting/tectonic#1207 ) tectonic-unwrapped, tectonic: fix build #333143
• teleport_15 @arianvp @justinas @sigma @tomberek @freezeboy @techknowlogick teleport_15: 15.3.7 -> 15.4.11 #333048
• turbo @dlip turbo: 1.13.2 -> 2.0.11; modernize; adopt #328295
• typst @drupol @figsoda @kanashimia typst: patch Cargo.lock for Rust 1.80 #333528
• typst-lsp @figsoda @GaetanLepage typst-lsp: fix by updating dependencies #336523
• vector @thoughtpolice @happysalada vector: fix compatibility with Rust 1.80 #336302
• vimPlugins.vim-clap (unmaintained) vimPlugins.vim-clap: 0.54 -> 0.54-unstable-2024-08-11 #334381
• watchmate @chuangzhu watchmate: 0.4.5 -> 0.5.2-unstable-2024-08-13 #340066
• wezterm @SuperSandro2000 @mimame wezterm: fix compilation with rust 1.80 #334818
• ytermusic @codebam

[aqrln]

prisma-engines is being fixed upstream in prisma/prisma-engines#4972 but we can also patch the lockfile in the current version in nixpkgs.

[alyssais]

You have 1-2 weeks, remember, so if it's being fixed upstream, you can probably wait.

[doronbehar]

Useful link for those who want to quote the build log error for the upstream maintainers:

https://hydra.nixos.org/jobset/nixpkgs/staging-next#tabs-jobs

[pbsds]

or do https://hydra.nixos.org/job/nixpkgs/staging-next/<ATTRIBUTEPATH>.x86_64-linux

[teutat3s]

I opened an issue in the upstream repo for garage:
https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/849

[drupol]

Typst 0.11.1 is not compatible with Rust 1.80.0, but the current development snapshot is.

[alyssais]

Oh right, I forgot to write above: upgrading to an unstable version is possible, at the package maintainer's discretion — it requires a judgement call on how usable/safe the unstable version will be. But getting upstream to make a release is of course the best!

[justinas]

teleport_15

I am somewhat inept in navigating Hydra. Could someone help me confirm whether teleport_15 is actually broken because of the Rust bump?

The last real failure I could find using the link in #332957 (comment) is this one, which seems specific to x86_64-darwin and caused by nodejs failing to compile, if I'm reading this right.

Teleport 15.3.7 does seem to be using a problematic version of the time crate.

Edit: confirmed locally that it does not build.

[alyssais]

I am somewhat inept in navigating Hydra. Could someone help me confirm whether teleport_15 is actually broken because of the Rust bump?

Hydra hasn't built it with 1.80 yet. If you try building it yourself on staging-next you should see that it's broken.

[bendlas]

It wasn't really feasible to hold back, because packages tend to start requiring new Rust versions very soon after release, and it also didn't make a lot of sense to keep 1.79.0 as well, because many of the affected packages haven't been touched in a year or more, so there'd be no assurance we'd be able to remove it any time soon.

Seems to me like that sentence there contains a wee contradiction. Either the rust updates will be trivial because all the upstreams are already on top of it XOR there is this shadow looming of 1.79 becoming abandonware that we'll have to forever carry.

Looking at the regression, it's the latter one. Indeed, with #333125 I already ran into one of the classics: With 1.80, client builds, but server doesn't without cargo update (as you predicted, @alyssais) but then after the cargo update client fails with many errors.

In this case, I was able to fix it, by building against two different lock files, but that's an ugly hack and was hard to find. Obviously, I did open an upstream issue, but if I don't find it reasonable to set a 2 week ultimatium within nixpkgs, then I find it even less reasonable to impose such limits onto our upstream developers. We are not in a corporate environment here.

On principle, rust 1.80 is a new language due to the incompatible change (however inadvertent), and should be treated as such. So I think we need to leave 1.79 in nixpkgs, a little while longer. We can, however, disable its hydra builds, such that downstream will learn about the issue through increased build times and have a chance to step up, before their toys break.

[archer-65]

@alyssais

• cargo-outdated :: cargo-outdated: fix build against Rust 1.80 due to outdated time dependency #335152
• cargo-update :: cargo-update: 14.0.2 -> 14.1.1 #337353 (should be fixed)
• gex :: gex: refactor #339540
• glide-media-player :: glide-media-player: 0.6.3 -> 0.6.5 #336814
• inlyne :: inlyne: 0.4.2 -> 0.4.3 #338369
• kdash :: kdash: 0.6.0 -> 0.6.1 #337994
• meli :: meli: 0.8.6 -> 0.8.7 #338258
• meme-bingo-web :: meme-bingo-web: 1.0.1 → 1.1.0 #334126
• fh :: fh: 0.1.10 -> 0.1.16, fix build #331327
• rerun :: rerun: 0.13.0 -> 0.18.2 #334854
• rune-languageserver :: rune-languageserver: 0.12.4 -> 0.13.4 #340336
• veloren :: veloren: fix build on rust 1.80 #335073
• codemov :: codemov: fix build with rust 1.80 #337418

[stigtsp]

Hi @alyssais, ripasso-cursive has been updated:

• ripasso-cursive: 0.6.4 -> 0.7.0 #340335

[brsvh]

@alyssais igrep has been updated:

• igrep: 1.2.0 -> 1.3.0 #340644
• Build failed at 1.2.0 with Rust 1.80.0 konradsz/igrep#69

[archer-65]

@alyssais

• mpris-notifier :: mpris-notifier: 0.1.7 -> 0.1.9 #340897
• sn0int :: sn0int: 0.26.0 -> 0.26.1 #342093
• svdtools :: svdtools: 0.3.17 -> 0.3.18 #333760
• lorri :: lorri: 1.7.0 -> 1.7.1 #335154
• rathole :: rathole: 0.5.0 -> 0.5.0-unstable-2024-06-06 #337095
• rune-languageserver :: rune-languageserver: 0.12.4 -> 0.13.4 #340336
• cargo-semver-checks :: cargo-semver-checks: 0.33.0 -> 0.34.0 #334718
• garage :: garage: update time to fix build with rust 1.80 #335280