Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external dependencies? #10

Open
igorgatis opened this issue Aug 26, 2014 · 6 comments
Open

Remove external dependencies? #10

igorgatis opened this issue Aug 26, 2014 · 6 comments

Comments

@igorgatis
Copy link

As an embeddable module, it would be nice if this project had no external dependencies. Looking at the code, it seems like log4net could be easily replaced by a delegate (passed as optional parameter to HttpServer constructor). I wonder whether JSON could also be handled by delegates. Alternatively, all controllers could live in separate DLL and that DLL would require Newtonsoft.Json.

@shanielh
Copy link

I might seperate the controllers and all other handlers to seperate package "uHttpSharp-extras" like some other open source projects do.

In that case, uHttpSharp will stay slim with only "core" classes, while uHttpSharp-extras will have the bundled handlers, controllers, modelBinders, etc'.

What do you think?

Shani.

@igorgatis
Copy link
Author

Looks good.

@shanielh
Copy link

Would you use uHttpSharp core without the bundled handlers, controllers, etc'..?

@igorgatis
Copy link
Author

I'm interested on mapping string (or regex) to a function. I don't mind the extra stuff. The external dependency is the biggest drawback.

@shanielh
Copy link

@igorgatis Log4net is not a dependency anymore, thanks to #13

@Psilax
Copy link

Psilax commented Apr 25, 2019

Can we update the other dependencies in a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants